Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Deprecated np.float with np.float64 in nd2reader #70

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

mansouralawi
Copy link
Contributor

Overview

This PR addresses the issue where np.float causes an attribute error in the nd2reader package. The error is due to the deprecation of np.float in newer versions of NumPy.

Changes

  • Replaced all instances of np.float with np.float64.

Related Issues

#69 #67

Notes

  • The change adheres to the recommendations found in the NumPy 1.20 release notes regarding the deprecation of np.float.

@clementhelsens
Copy link

Thanks for this, I also encountered the same issue using a more recent version of numpy and had to implement the same fixes as yours. Hope the authors will merge and release a new version soon such that we do not need to patch the code

@ggirelli
Copy link
Contributor

Is this change backward compatible with older numpy versions? If not, we should at least update the requirements https://github.com/Open-Science-Tools/nd2reader/blob/master/requirements.txt

@rbnvrw
Copy link
Member

rbnvrw commented Jan 15, 2025

Thank you so much and apologies for the delay in responding. I'm no longer working in this field and can't maintain the repository any longer due to various reasons. If anyone would like to help out, please reach out to me.

The 3.7 test is failing because that python version is no longer on github, I'll merge this PR and thank you again so much for your contribution.

@rbnvrw rbnvrw merged commit 23b4c8c into Open-Science-Tools:master Jan 15, 2025
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants